gh-102978: Fix mock.patch function signatures for class and staticmethod decorators #103228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
sobolevn
reviewed
Apr 4, 2023
Misc/NEWS.d/next/Library/2023-04-03-23-44-34.gh-issue-102978.gy9eVk.rst
Outdated
Show resolved
Hide resolved
arhadthedev
added
the
stdlib
tomasr8
force-pushed
the
gh-102978
branch
2 times, most recently
from
ab55da7 to
ade55ef
Compare
sobolevn
reviewed
Apr 4, 2023
|
Thanks! I updated the tests |
sobolevn
reviewed
Apr 4, 2023
|
Awesome, thanks for your time! |
tomasr8
force-pushed
the
gh-102978
branch
2 times, most recently
from
a1b5a6b to
98f562e
Compare
Fixes unittest.mock.patch not enforcing function signatures for methods decorated with @classmethod or @staticmethod when patch is called with autospec=True.
|
GH-103499 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 13, 2023
…ticmethod decorators (pythonGH-103228) Fixes unittest.mock.patch not enforcing function signatures for methods decorated with @classmethod or @staticmethod when patch is called with autospec=True. (cherry picked from commit 59e0de4) Co-authored-by: Tomas R <[email protected]>
carljm
added a commit
to carljm/cpython
that referenced
this pull request
Apr 13, 2023
* main: pythongh-103479: [Enum] require __new__ to be considered a data type (pythonGH-103495) pythongh-103365: [Enum] STRICT boundary corrections (pythonGH-103494) pythonGH-103488: Use return-offset, not yield-offset. (pythonGH-103502) pythongh-103088: Fix test_venv error message to avoid bytes/str warning (pythonGH-103500) pythonGH-103082: Turn on branch events for FOR_ITER instructions. (python#103507) pythongh-102978: Fix mock.patch function signatures for class and staticmethod decorators (python#103228) pythongh-103462: Ensure SelectorSocketTransport.writelines registers a writer when data is still pending (python#103463) pythongh-95299: Rework test_cppext.py to not invoke setup.py directly (python#103316)
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Apr 18, 2023
…ticmethod decorators (python#103228) Fixes unittest.mock.patch not enforcing function signatures for methods decorated with @classmethod or @staticmethod when patch is called with autospec=True.
ambv
pushed a commit
that referenced
this pull request
May 22, 2023
…aticmethod decorators (GH-103228) (#103499) Fixes unittest.mock.patch not enforcing function signatures for methods decorated with @classmethod or @staticmethod when patch is called with autospec=True. (cherry picked from commit 59e0de4) Co-authored-by: Tomas R <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #102978
As reported in the original issue,
unittest.mock.patchdoes not correctly extract function signatures from methods decorated with@classmethodand@staticmethodwhenpatchis called withautospec=True.This fix adds a special case to the extraction logic which uses the original decorated function via
__func__to get the correct signature.I also updated the relevant tests.