[3.11] gh-101283: Improved fallback logic for subprocess with shell=True on Windows (GH-101286) #101711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

miss-islington merged 2 commits into python:3.11 from miss-islington:backport-23751ed-3.11

Feb 8, 2023

Contributor

miss-islington commented Feb 8, 2023 •

edited by bedevere-bot

Loading

(cherry picked from commit 23751ed)

Co-authored-by: Oleg Iarygin [email protected]

Issue: Undocumented risky behaviour in subprocess module #101283


          pythongh-101283: Improved fallback logic for subprocess with shell=Tr…

644134d

…ue on Windows (pythonGH-101286)

(cherry picked from commit 23751ed)

Co-authored-by: Oleg Iarygin <[email protected]>

miss-islington requested a review from gpshead as a code owner

February 8, 2023 22:14

bedevere-bot added the awaiting review label

This was referenced Feb 8, 2023

Undocumented risky behaviour in subprocess module #101283

Closed

gh-101283: Try to load the fallback cmd.exe by an absolute path #101286

Merged

bedevere-bot added the type-security label

zooba reviewed

View reviewed changes

Lib/subprocess.py Show resolved Hide resolved


          Update Lib/subprocess.py

3762cc4

gpshead requested changes

View reviewed changes

Doc/library/subprocess.rst

    
                    Added the *text* parameter, as a more understandable alias of *universal_newlines*.

                    Added the *capture_output* parameter.

                 .. versionchanged:: 3.11.2

Member

gpshead Feb 8, 2023

this version number is wrong everywhere. 3.11.2 was just released.

bedevere-bot removed the awaiting review label

bedevere-bot commented Feb 8, 2023

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

bedevere-bot added the awaiting changes label

zooba approved these changes

View reviewed changes

Doc/library/subprocess.rst

    
                    Added the *text* parameter, as a more understandable alias of *universal_newlines*.

                    Added the *capture_output* parameter.

                 .. versionchanged:: 3.11.2

Member

zooba Feb 8, 2023

Suggested change

      
               .. versionchanged:: 3.11.2
          
               .. versionchanged:: 3.11.3

Doc/library/subprocess.rst

    
                    *executable* parameter accepts a bytes and :term:`path-like object`

                    on Windows.

                 .. versionchanged:: 3.11.2

Member

zooba Feb 8, 2023

Suggested change

      
               .. versionchanged:: 3.11.2
          
               .. versionchanged:: 3.11.3

Doc/library/subprocess.rst

    
                 .. versionchanged:: 3.3

                    *timeout* was added.

                 .. versionchanged:: 3.11.2

Member

zooba Feb 8, 2023

Suggested change

      
               .. versionchanged:: 3.11.2
          
               .. versionchanged:: 3.11.3

Doc/library/subprocess.rst

    
                 .. versionchanged:: 3.3

                    *timeout* was added.

                 .. versionchanged:: 3.11.2

Member

zooba Feb 8, 2023

Suggested change

      
               .. versionchanged:: 3.11.2
          
               .. versionchanged:: 3.11.3

Doc/library/subprocess.rst

    
                 .. versionadded:: 3.7

                    *text* was added as a more readable alias for *universal_newlines*.

                 .. versionchanged:: 3.11.2

Member

zooba Feb 8, 2023

Suggested change

      
               .. versionchanged:: 3.11.2
          
               .. versionchanged:: 3.11.3

bedevere-bot added awaiting merge and removed awaiting changes labels

miss-islington merged commit 51b079a into python:3.11

bedevere-bot removed the awaiting merge label

miss-islington deleted the backport-23751ed-3.11 branch

February 8, 2023 23:44

Member

zooba commented Feb 8, 2023

Whoops 😆 Forgot that hitting approve would merge it immediately

#101719 will backport to it at least

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels