Skip to content

gh-101056: Fix memory leak in formatfloat() in bytesobject.c #101057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2023
Merged

gh-101056: Fix memory leak in formatfloat() in bytesobject.c #101057

merged 1 commit into from
Jan 16, 2023

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Jan 15, 2023 •
edited
Loading

Docs say:

The return value is a pointer to *buffer* with the converted string or
   ``NULL`` if the conversion failed. The caller is responsible for freeing the
   returned string by calling :c:func:`PyMem_Free`.

@bedevere-bot bedevere-bot mentioned this pull request Jan 15, 2023
Closed
mdickinson
mdickinson approved these changes Jan 15, 2023
View reviewed changes
Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Probably worth running the buildbots on this, though.

@mdickinson mdickinson added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 15, 2023
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @mdickinson for commit 8e1b415 🤖

If you want to schedule another build, you need to add the :hammer: test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 15, 2023
@kumaraditya303 kumaraditya303 merged commit b1a74a1 into python:main Jan 16, 2023
@kumaraditya303 kumaraditya303 added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Jan 16, 2023
@miss-islington
Copy link
Contributor

Thanks @sobolevn for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @sobolevn for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-101076 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jan 16, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 16, 2023
@sobolevn @miss-islington
pythongh-101056: Fix memory leak in formatfloat() in bytesobject.c (
e9cc8a8 
pythonGH-101057)

(cherry picked from commit b1a74a1)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-bot
Copy link

GH-101077 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jan 16, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 16, 2023
@sobolevn @miss-islington
pythongh-101056: Fix memory leak in formatfloat() in bytesobject.c (
9d7c1e4 
pythonGH-101057)

(cherry picked from commit b1a74a1)

Co-authored-by: Nikita Sobolev <[email protected]>
miss-islington added a commit that referenced this pull request Jan 16, 2023
@miss-islington @sobolevn
gh-101056: Fix memory leak in formatfloat() in bytesobject.c (GH-…
63690e9 
…101057)

(cherry picked from commit b1a74a1)

Co-authored-by: Nikita Sobolev <[email protected]>
miss-islington added a commit that referenced this pull request Jan 16, 2023
@miss-islington @sobolevn
gh-101056: Fix memory leak in formatfloat() in bytesobject.c (GH-…
664141e 
…101057)

(cherry picked from commit b1a74a1)

Co-authored-by: Nikita Sobolev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdickinson mdickinson mdickinson approved these changes

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sobolevn @bedevere-bot @miss-islington @mdickinson @kumaraditya303