Skip to content

Fix typo in SourceLoader.path_stats docstring #10052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 25, 2018
Merged

Fix typo in SourceLoader.path_stats docstring #10052

merged 3 commits into from
Oct 25, 2018

Conversation

kwentine
Copy link
Contributor

No description provided.

@kwentine
Copy link
Contributor Author

First corrects a typo and then tries to phrase parameter type hints consistently in docstrings of SourceLoader methods.

vstinner
vstinner approved these changes Oct 24, 2018
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

But you have to regenerate importlib genereated files. Use "make regen-importlib" on Linux for example.

@kwentine
Copy link
Contributor Author

Ran ./configure && make regen-importlib (no pretending to understand more than roughly what it does ^^)

@vstinner vstinner merged commit d7c3e5f into python:master Oct 25, 2018
@miss-islington
Copy link
Contributor

Thanks @qagren for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @qagren and @vstinner, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker d7c3e5f0e89cb807093e33165815c8bbd3c00f4b 3.7

@miss-islington
Copy link
Contributor

Sorry, @qagren and @vstinner, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker d7c3e5f0e89cb807093e33165815c8bbd3c00f4b 3.6

@vstinner
Copy link
Member

I attempted to automatically backport this change to 3.6 and 3.7 but there are conflict. I don't think that it's worth it to backport it manually, so I close the PR. Thanks @qagren for your fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@brettcannon brettcannon Awaiting requested review from brettcannon

@ncoghlan ncoghlan Awaiting requested review from ncoghlan

Assignees

@vstinner vstinner

Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kwentine @miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot