Skip to content

GH-95234 introduced an incorrect condition in the code #96125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kanavin opened this issue Aug 19, 2022 · 2 comments
Closed

GH-95234 introduced an incorrect condition in the code #96125

kanavin opened this issue Aug 19, 2022 · 2 comments
Labels
3.11 only security fixes 3.12 only security fixes type-bug An unexpected behavior, bug, or error

Comments

@kanavin
Copy link
Contributor

kanavin commented Aug 19, 2022

In Python/thread.c

#elif defined(_POSIX_THREADS)
#   if defined(__EMSCRIPTEN__) || !defined(__EMSCRIPTEN_PTHREADS__)
#     define PYTHREAD_NAME "pthread-stubs"
#   else
#     define PYTHREAD_NAME "pthread"
#   endif

|| should be &&.
@kanavin kanavin added the type-bug An unexpected behavior, bug, or error label Aug 19, 2022
@kanavin kanavin mentioned this issue Aug 19, 2022
Merged
@tiran tiran added 3.11 only security fixes 3.12 only security fixes labels Aug 19, 2022
@tiran
Copy link
Member

tiran commented Aug 19, 2022

Good catch!

tiran added a commit to tiran/cpython that referenced this issue Aug 19, 2022
@tiran
pythongh-96125: Fix sys.thread_info.name on pthread platforms
cab7a9a
tiran added a commit to tiran/cpython that referenced this issue Aug 19, 2022
@tiran
pythongh-96125: Fix sys.thread_info.name on pthread platforms
8334be0
tiran added a commit to tiran/cpython that referenced this issue Aug 19, 2022
@tiran
pythongh-96125: Fix sys.thread_info.name on pthread platforms
4357c9d
@bedevere-bot bedevere-bot mentioned this issue Aug 19, 2022
Merged
miss-islington pushed a commit that referenced this issue Aug 19, 2022
@tiran
gh-96125: Fix sys.thread_info.name on pthread platforms (GH-96126)
822955c 
Automerge-Triggered-By: GH:tiran
@bedevere-bot bedevere-bot mentioned this issue Aug 19, 2022
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 19, 2022
@tiran @miss-islington
pythongh-96125: Fix sys.thread_info.name on pthread platforms (python…
d8ad9a7 
…GH-96126)

Automerge-Triggered-By: GH:tiran
(cherry picked from commit 822955c)

Co-authored-by: Christian Heimes <[email protected]>
pablogsal pushed a commit that referenced this issue Aug 21, 2022
@miss-islington @tiran
gh-96125: Fix sys.thread_info.name on pthread platforms (GH-96126) (#…
27f390b 
…96128)

Automerge-Triggered-By: GH:tiran
(cherry picked from commit 822955c)

Co-authored-by: Christian Heimes <[email protected]>

Co-authored-by: Christian Heimes <[email protected]>
@gpshead
Copy link
Member

gpshead commented Sep 13, 2022

both merged, looks fixed.

@gpshead gpshead closed this as completed Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.11 only security fixes 3.12 only security fixes type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gpshead @tiran @kanavin