inspect.getsource(SomeClass) doesn't show @decorators

[takluyver]

BPO	15856
Nosy	@takluyver, @1st1, @tirkarthi
Superseder	bpo-35113: inspect.getsource returns incorrect source for classes when class definition is part of multiline strings

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2019-08-31.10:47:09.340>
created_at = <Date 2012-09-03.15:13:44.404>
labels = ['3.8', 'type-bug', 'library']
title = "inspect.getsource(SomeClass) doesn't show @decorators"
updated_at = <Date 2020-04-18.16:19:39.465>
user = 'https://github.com/takluyver'

bugs.python.org fields:

activity = <Date 2020-04-18.16:19:39.465>
actor = 'xtreak'
assignee = 'none'
closed = True
closed_date = <Date 2019-08-31.10:47:09.340>
closer = 'serhiy.storchaka'
components = ['Library (Lib)']
creation = <Date 2012-09-03.15:13:44.404>
creator = 'takluyver'
dependencies = []
files = []
hgrepos = []
issue_num = 15856
keywords = []
message_count = 4.0
messages = ['169767', '222682', '340966', '366726']
nosy_count = 3.0
nosy_names = ['takluyver', 'yselivanov', 'xtreak']
pr_nums = []
priority = 'normal'
resolution = 'duplicate'
stage = 'resolved'
status = 'closed'
superseder = '35113'
type = 'behavior'
url = 'https://bugs.python.org/issue15856'
versions = ['Python 3.8']

[takluyver]

Since bug bpo-1006219 was fixed, inspect.getsource(func) has returned the source of a function including any decorators on the function. But doing the same with a class, the returned source doesn't include decorators.

With functions, the co_firstlineno attribute of the code object points to the start of the decorators. With classes, that's not possible, so it's likely that a bit more regex trickery will be needed to scan back to decorators.

I've confirmed the same thing happens in 3.2 and 2.7, and looking at the code of inspect.py in trunk, it looks like it will do the same thing.

[BreamoreBoy]

@thomas sorry about the delay in getting back to you.

[tirkarthi]

This should be resolved by bpo-35113 . I have rewritten the getsource function for classes to use AST to deal with nested classes. The PR adds support for showing the decorator in the source. I would propose closing this as a duplicate of the other issue.

[tirkarthi]

New changeset 696136b by Karthikeyan Singaravelan in branch 'master':
bpo-35113: Fix inspect.getsource to return correct source for inner classes (bpo-10307)
696136b