Skip to content

Finish deprecation period for some sqlite3.Connection APIs #133595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
serhiy-storchaka opened this issue May 7, 2025 · 4 comments
Open

Finish deprecation period for some sqlite3.Connection APIs #133595

serhiy-storchaka opened this issue May 7, 2025 · 4 comments
Assignees
@erlend-aasland
Labels
3.15 new features, bugs and security fixes extension-modules C modules in the Modules dir topic-sqlite3

Comments

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented May 7, 2025 •
edited by bedevere-app bot
Loading

This is a continuation of #108278.

Passing some arguments by keyword or as positional was deprecated in 3.13. It is time to finish the deprecation period.

Linked PRs
@serhiy-storchaka serhiy-storchaka added topic-sqlite3 3.15 new features, bugs and security fixes labels May 7, 2025
@serhiy-storchaka serhiy-storchaka self-assigned this May 7, 2025
@picnixz picnixz added the extension-modules C modules in the Modules dir label May 7, 2025
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue May 7, 2025
@serhiy-storchaka
pythongh-133595: Clean up sqlite3.Connection APIs
d60e936 
* All parameters of sqlite3.connect() except "database" are now keyword-only.
* The first three parameters of methods create_function() and
  create_aggregate() are now positional-only.
* The first parameter of methods set_authorizer(), set_progress_handler()
  and set_trace_callback() is now positional-only.
@bedevere-app bedevere-app bot mentioned this issue May 7, 2025
Merged
serhiy-storchaka added a commit that referenced this issue May 8, 2025
@serhiy-storchaka
gh-133595: Clean up sqlite3.Connection APIs (GH-133605)
dcf93c4 
* All parameters of sqlite3.connect() except "database" are now keyword-only.
* The first three parameters of methods create_function() and
  create_aggregate() are now positional-only.
* The first parameter of methods set_authorizer(), set_progress_handler()
  and set_trace_callback() is now positional-only.
@serhiy-storchaka
Copy link
Member Author

Now we finally can do the changes planned in #108278 and harmonize parameter names (like narg/n_arg/num_params). @erlend-aasland, do you want to do this?

@erlend-aasland
Copy link
Contributor

Now we finally can do the changes planned in #108278 and harmonize parameter names (like narg/n_arg/num_params). @erlend-aasland, do you want to do this?

Yes, let's harmonise them.

@serhiy-storchaka
Copy link
Member Author

Then I leave it to you. I only rushed #133605 because the compilation warnings were annoying me.

I have also noticed that we missed to remove some deprecated features in 3.14.

@erlend-aasland
Copy link
Contributor

I have also noticed that we missed to remove some deprecated features in 3.14.

I'll have a look and adjust the deprecation periods to 3.15.

@erlend-aasland erlend-aasland self-assigned this May 8, 2025
@serhiy-storchaka serhiy-storchaka removed their assignment May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erlend-aasland erlend-aasland

Labels
3.15 new features, bugs and security fixes extension-modules C modules in the Modules dir topic-sqlite3
Projects
sqlite3 issues
Status: No status
Milestone
No milestone
Development

No branches or pull requests
3 participants
@serhiy-storchaka @picnixz @erlend-aasland