-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
test_keywords
in test_popen
can be improved
#131234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
sobolevn
added a commit
to sobolevn/cpython
that referenced
this issue
Mar 14, 2025
sobolevn
added a commit
that referenced
this issue
Mar 14, 2025
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
Mar 14, 2025
) (cherry picked from commit fc07f86) Co-authored-by: sobolevn <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
Mar 14, 2025
) (cherry picked from commit fc07f86) Co-authored-by: sobolevn <[email protected]>
This was referenced Mar 14, 2025
sobolevn
added a commit
that referenced
this issue
Mar 14, 2025
…131241) gh-131234: Improve `test_popen` with more asserts (GH-131235) (cherry picked from commit fc07f86) Co-authored-by: sobolevn <[email protected]>
sobolevn
added a commit
that referenced
this issue
Mar 14, 2025
…131240) gh-131234: Improve `test_popen` with more asserts (GH-131235) (cherry picked from commit fc07f86) Co-authored-by: sobolevn <[email protected]>
mikec9
pushed a commit
to mikec9/cpython
that referenced
this issue
Mar 14, 2025
…nGH-131235) (python#131241) pythongh-131234: Improve `test_popen` with more asserts (pythonGH-131235) (cherry picked from commit fc07f86) Co-authored-by: sobolevn <[email protected]>
plashchynski
pushed a commit
to plashchynski/cpython
that referenced
this issue
Mar 17, 2025
seehwan
pushed a commit
to seehwan/cpython
that referenced
this issue
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug report
test_keywords
here:cpython/Lib/test/test_popen.py
Lines 65 to 68 in 7fd6160
does not assert anything. I propose to use an example similar to this one:
cpython/Lib/test/test_popen.py
Lines 57 to 59 in 7fd6160
and at least assert that the expected program executed and that
f
is still not closed inwith
body.I have a PR ready.
Linked PRs
test_popen
with more asserts #131235test_popen
with more asserts (GH-131235) #131240test_popen
with more asserts (GH-131235) #131241The text was updated successfully, but these errors were encountered: