Skip to content

pygettext: Remove unused option -a/--extract-all #130195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
StanFromIreland opened this issue Feb 16, 2025 · 5 comments
Closed

pygettext: Remove unused option -a/--extract-all #130195

StanFromIreland opened this issue Feb 16, 2025 · 5 comments
Labels
triaged The issue has been accepted as valid by a triager. type-feature A feature request or enhancement

Comments

@StanFromIreland
Copy link
Contributor

StanFromIreland commented Feb 16, 2025 •
edited by bedevere-app bot
Loading

It has never been implemented. PR soon

@tomasr8

Linked PRs
@bedevere-app bedevere-app bot mentioned this issue Feb 16, 2025
Merged
@gvanrossum
Copy link
Member

I'd be careful removing this flag. It could exist for "compatibility" with other tools that have a similar interface, and not supporting it might break people's scripts when they have flexibility in the tool used.

If it were me I'd just print a warning and continue to do nothing.

@StanFromIreland
Copy link
Contributor Author

I see, I will change it then.

@picnixz picnixz added type-feature A feature request or enhancement triaged The issue has been accepted as valid by a triager. labels Feb 16, 2025
gvanrossum pushed a commit that referenced this issue Feb 18, 2025
@StanFromIreland @tomasr8
gh-130195: Remove unimplemented option from pygettext (#130196)
4374e1d 
Co-authored-by: Tomas R. <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue Feb 18, 2025
Merged
@serhiy-storchaka
Copy link
Member

Why not just implement this feature? It is trivial, it only needs adding one if.

@gvanrossum
Copy link
Member

Why not just implement this feature? It is trivial, it only needs adding one if.

Go right ahead in that case!

@tomasr8
Copy link
Member

tomasr8 commented Mar 13, 2025

I'm neutral on this as I've never needed this feature myself but if someone wants to implement it, why not..
Otherwise I'd leave it until someone actually asks for it.

hugovk pushed a commit that referenced this issue Apr 24, 2025
@StanFromIreland @merwok
gh-130195: Fix typo in warning message (#130254)
92985e3 
Co-authored-by: Éric <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
triaged The issue has been accepted as valid by a triager. type-feature A feature request or enhancement
Projects
Gettext issues
Status: Done
Milestone
No milestone
Development

No branches or pull requests
5 participants
@gvanrossum @serhiy-storchaka @tomasr8 @picnixz @StanFromIreland