-
-
Notifications
You must be signed in to change notification settings - Fork 32.7k
Closed
Labels
buildThe build process and cross-buildThe build process and cross-buildtype-featureA feature request or enhancementA feature request or enhancement
Description
Feature or enhancement
Currently our regen-all
is missing several regen-
targets:
@echo "Note: make regen-stdlib-module-names, make regen-limited-abi, "
@echo "make regen-configure, make regen-sbom, and make regen-unicodedata should be run manually"
While our CI job to check regenerated files does not check them:
cpython/.github/workflows/build.yml
Lines 120 to 124 in 2a6b6b3
- name: Build CPython | |
run: | | |
make -j4 regen-all | |
make regen-stdlib-module-names regen-sbom | |
- name: Check for changes |
This does not seem right, I think that we should add:
make regen-unicodedata
(it requires internet access, but GitHub jobs always have access, see gh-96954: Don't run regen-unicodedata in regen-all #112120)make regen-limited-abi
(needs to compile python to get the ABI)
How long does it work? Testing locally first:
make regen-unicodedata 9.44s user 0.47s system 27% cpu 35.719 total
make regen-limited-abi 2.35s user 0.76s system 77% cpu 4.019 total (with pre-existing cache)
I propose adding these two make
targets to the test to be extra safe.
What do others think? :)
If agreed, I will send a PR.
Linked PRs
- gh-126524: Run
regen-unicodedata
as a part of our CI #126682 - [3.13] gh-126524: Run
regen-unicodedata
as a part of our CI (GH-126682) #127594 - [3.12] gh-126524: Run
regen-unicodedata
as a part of our CI (GH-126682) #127595 - gh-126524: Revert "gh-126524: Run
regen-unicodedata
as a part of our CI #126682" #138197 - [3.14] gh-126524: Revert "gh-126524: Run
regen-unicodedata
as a part of our CI GH-126682" (GH-138197) #138218
Metadata
Metadata
Assignees
Labels
buildThe build process and cross-buildThe build process and cross-buildtype-featureA feature request or enhancementA feature request or enhancement