Skip to content

Incomplete test coverage for ast.get_docstring #121671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tomasr8 opened this issue Jul 13, 2024 · 1 comment
Closed

Incomplete test coverage for ast.get_docstring #121671

tomasr8 opened this issue Jul 13, 2024 · 1 comment
Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@tomasr8
Copy link
Member

tomasr8 commented Jul 13, 2024 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

The ast.get_docstring is missing test coverage:

image

I'll send a PR with some additional tests ;)

CPython versions tested on:

CPython main branch

Operating systems tested on:

Linux

Linked PRs
@tomasr8 tomasr8 added the type-bug An unexpected behavior, bug, or error label Jul 13, 2024
@Eclips4 Eclips4 added the tests Tests in the Lib/test dir label Jul 13, 2024
@bedevere-app bedevere-app bot mentioned this issue Jul 13, 2024
Merged
encukou pushed a commit that referenced this issue Jul 13, 2024
@tomasr8
gh-121671: Increase test coverage of ast.get_docstring (GH-121674)
0a26aa5 
Increase test coverage for `ast.get_docstring`
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 13, 2024
@tomasr8 @miss-islington
pythongh-121671: Increase test coverage of ast.get_docstring (pytho…
656a5b0 
…nGH-121674)

Increase test coverage for `ast.get_docstring`
(cherry picked from commit 0a26aa5)

Co-authored-by: Tomas R <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue Jul 13, 2024
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 13, 2024
@tomasr8 @miss-islington
pythongh-121671: Increase test coverage of ast.get_docstring (pytho…
f47d9d6 
…nGH-121674)

Increase test coverage for `ast.get_docstring`
(cherry picked from commit 0a26aa5)

Co-authored-by: Tomas R <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue Jul 13, 2024
Merged
encukou pushed a commit that referenced this issue Jul 13, 2024
@miss-islington @tomasr8
[3.12] gh-121671: Increase test coverage of ast.get_docstring (GH-1…
e32b752 
…21674) (GH-121690)

(cherry picked from commit 0a26aa5)

Co-authored-by: Tomas R <[email protected]>
encukou pushed a commit that referenced this issue Jul 13, 2024
@miss-islington @tomasr8
[3.13] gh-121671: Increase test coverage of ast.get_docstring (GH-1…
5e8bb98 
…21674) (GH-121691)

(cherry picked from commit 0a26aa5)

Co-authored-by: Tomas R <[email protected]>
@encukou
Copy link
Member

encukou commented Jul 13, 2024

Thank you for the fix!

@encukou encukou closed this as completed Jul 13, 2024
IljaManakov pushed a commit to IljaManakov/cpython that referenced this issue Jul 13, 2024
@tomasr8 @IljaManakov
pythongh-121671: Increase test coverage of ast.get_docstring (pytho…
e0c9d80 
…nGH-121674)

Increase test coverage for `ast.get_docstring`
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
@tomasr8 @estyxx
pythongh-121671: Increase test coverage of ast.get_docstring (pytho…
49fbc0f 
…nGH-121674)

Increase test coverage for `ast.get_docstring`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@encukou @tomasr8 @Eclips4