Skip to content

Adapt TestStaticTypes to use @no_rerun #119667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sobolevn opened this issue May 28, 2024 · 1 comment
Open

Adapt TestStaticTypes to use @no_rerun #119667

sobolevn opened this issue May 28, 2024 · 1 comment
Assignees
Labels
tests Tests in the Lib/test dir type-feature A feature request or enhancement

Comments

@sobolevn
Copy link
Member

sobolevn commented May 28, 2024

Feature or enhancement

Refs #119660

Right now this class re-implements @no_rerun decorator:

class TestStaticTypes(unittest.TestCase):
_has_run = False
@classmethod
def setUpClass(cls):
# The tests here don't play nice with our approach to refleak
# detection, so we bail out in that case.
if cls._has_run:
raise unittest.SkipTest('these tests do not support re-running')
cls._has_run = True

It is worth fixing.
I will send a PR.

@sobolevn sobolevn added type-feature A feature request or enhancement tests Tests in the Lib/test dir labels May 28, 2024
@sobolevn sobolevn self-assigned this May 28, 2024
@sobolevn
Copy link
Member Author

Blocker: #119675

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Tests in the Lib/test dir type-feature A feature request or enhancement
Projects
None yet
Development

No branches or pull requests

1 participant