-
-
Notifications
You must be signed in to change notification settings - Fork 32.9k
Closed
Labels
interpreter-core(Objects, Python, Grammar, and Parser dirs)(Objects, Python, Grammar, and Parser dirs)type-featureA feature request or enhancementA feature request or enhancement
Description
In bytecodes.c we use both next_instr - this_instr
and 1 + INLINE_CACHE_ENTRIES_...
to mean "instruction length".
We should add a macro for the purpose that is understood by the code generator.
Examples
The somewhat confusing LOAD_IP(1 + INLINE_CACHE_ENTRIES_SEND);
would become LOAD_IP(INSTRUCTION_LENGTH)
frame->return_offset = (uint16_t)(next_instr - this_instr);
would become frame->return_offset = INSTRUCTION_LENGTH;
which is both easier to understand and wouldn't be rejected as tier 2 code.
Linked PRs
iritkatriel and Fidget-Spinner
Metadata
Metadata
Assignees
Labels
interpreter-core(Objects, Python, Grammar, and Parser dirs)(Objects, Python, Grammar, and Parser dirs)type-featureA feature request or enhancementA feature request or enhancement