Skip to content

Add tests for os.chmod() and os.lchmod() #113086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
serhiy-storchaka opened this issue Dec 14, 2023 · 0 comments
Closed

Add tests for os.chmod() and os.lchmod() #113086

serhiy-storchaka opened this issue Dec 14, 2023 · 0 comments
Assignees
@serhiy-storchaka
Labels
3.11 only security fixes 3.12 only security fixes 3.13 bugs and security fixes tests Tests in the Lib/test dir

Comments

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Dec 14, 2023 •
edited by bedevere-app bot
Loading

Currently only tests that test os.chmod() and os.lchmod() are tests that they raise exceptions for invalid arguments. There are no tests for working os.chmod() and os.lchmod() and their behavior with symlinks (there is a difference between Windows and POSIX).

Linked PRs
@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir 3.11 only security fixes 3.12 only security fixes 3.13 bugs and security fixes labels Dec 14, 2023
@serhiy-storchaka serhiy-storchaka self-assigned this Dec 14, 2023
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Dec 14, 2023
@serhiy-storchaka
pythongh-113086: Add tests for os.chmod() and os.lchmod()
9ee5c7b 
Also make test_copymode_symlink_to_symlink in test_shutil more strict.
This was referenced Dec 14, 2023
Merged
Merged
serhiy-storchaka added a commit that referenced this issue Dec 14, 2023
@serhiy-storchaka
gh-113086: Add tests for os.chmod() and os.lchmod() (GH-113087)
b4f2c89 
Also make test_copymode_symlink_to_symlink in test_shutil more strict.
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Dec 14, 2023
@serhiy-storchaka @miss-islington
pythongh-113086: Add tests for os.chmod() and os.lchmod() (pythonGH-1…
ffb8412 
…13087)

Also make test_copymode_symlink_to_symlink in test_shutil more strict.
(cherry picked from commit b4f2c89)

Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Dec 14, 2023
@serhiy-storchaka @miss-islington
pythongh-113086: Add tests for os.chmod() and os.lchmod() (pythonGH-1…
f010576 
…13087)

Also make test_copymode_symlink_to_symlink in test_shutil more strict.
(cherry picked from commit b4f2c89)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue Dec 14, 2023
Merged
serhiy-storchaka added a commit that referenced this issue Dec 14, 2023
@miss-islington @serhiy-storchaka
[3.12] gh-113086: Add tests for os.chmod() and os.lchmod() (GH-113087) (
0bd1899 
GH-113088)

Also make test_copymode_symlink_to_symlink in test_shutil more strict.
(cherry picked from commit b4f2c89)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit that referenced this issue Dec 14, 2023
@miss-islington @serhiy-storchaka
[3.11] gh-113086: Add tests for os.chmod() and os.lchmod() (GH-113087) (
e4cdb74 
GH-113089)

Also make test_copymode_symlink_to_symlink in test_shutil more strict.
(cherry picked from commit b4f2c89)

Co-authored-by: Serhiy Storchaka <[email protected]>
corona10 pushed a commit to corona10/cpython that referenced this issue Dec 15, 2023
@serhiy-storchaka @corona10
pythongh-113086: Add tests for os.chmod() and os.lchmod() (pythonGH-1…
59bcb6c 
…13087)

Also make test_copymode_symlink_to_symlink in test_shutil more strict.
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
@serhiy-storchaka @aisk
pythongh-113086: Add tests for os.chmod() and os.lchmod() (pythonGH-1…
2224761 
…13087)

Also make test_copymode_symlink_to_symlink in test_shutil more strict.
Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
@serhiy-storchaka @Glyphack
pythongh-113086: Add tests for os.chmod() and os.lchmod() (pythonGH-1…
822db63 
…13087)

Also make test_copymode_symlink_to_symlink in test_shutil more strict.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@serhiy-storchaka serhiy-storchaka

Labels
3.11 only security fixes 3.12 only security fixes 3.13 bugs and security fixes tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@serhiy-storchaka