Skip to content

Docs: the calendar module lacks documentation for several APIs #108202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
erlend-aasland opened this issue Aug 21, 2023 · 4 comments
Open

Docs: the calendar module lacks documentation for several APIs #108202

erlend-aasland opened this issue Aug 21, 2023 · 4 comments
Labels
docs Documentation in the Doc dir

Comments

@erlend-aasland
Copy link
Contributor

erlend-aasland commented Aug 21, 2023

But first than documenting these particular method or two, we should decide whether they should be documented at all.

See past issues with the calendar module. There may be requests for undocumented methods, and some of them may even be rejected already. I think this has already been discussed.

Originally posted by @serhiy-storchaka in #108192 (comment)

Linked PRs

@erlend-aasland erlend-aasland added the docs Documentation in the Doc dir label Aug 21, 2023
@hugovk hugovk changed the title Docs: the calendar module lacks documentation for several APIS Docs: the calendar module lacks documentation for several APIs Aug 21, 2023
@AA-Turner
Copy link
Member

AA-Turner commented Aug 21, 2023

(status as at 21c0844)

Defined in __all__ but not documented

Undocumented classes

  • different_locale (should not be documented, helper class)

Undocumented functions

  • prweek()
  • week()
  • format()
  • formatstring()

Undocumented methods

Calendar

TextCalendar

HTMLCalendar

  • HTMLCalendar.formatday()
  • HTMLCalendar.formatweek()
  • HTMLCalendar.formatweekday()
  • HTMLCalendar.formatweekheader()
  • HTMLCalendar.formatmonthname()

Undocumented attributes

  • EPOCH (should not be documented, of no use)
  • mdays (should not be documented, of no use)

Undocumented miscellany

A

@AA-Turner
Copy link
Member

I think at the least we ought document IllegalMonthError and IllegalWeekdayError, I'll open a PR shortly.

A

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 25, 2023
(cherry picked from commit 1350987)

Co-authored-by: Adam Turner <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 25, 2023
(cherry picked from commit 1350987)

Co-authored-by: Adam Turner <[email protected]>
hugovk pushed a commit that referenced this issue Aug 25, 2023
Yhg1s pushed a commit that referenced this issue Aug 25, 2023
GH-108202: Document ``calendar`` exceptions (GH-108398)
(cherry picked from commit 1350987)

Co-authored-by: Adam Turner <[email protected]>
AA-Turner added a commit to AA-Turner/cpython that referenced this issue Aug 28, 2023
…ts (pythonGH-108492).

(cherry picked from commit 5d936b6)

Co-authored-by: Adam Turner <[email protected]>
Yhg1s pushed a commit that referenced this issue Aug 28, 2023
…-108492) (#108579)

[3.12] GH-108202: Combine documentation of ``calendar`` constants (GH-108492).
(cherry picked from commit 5d936b6)
hugovk added a commit that referenced this issue Sep 6, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Sep 6, 2023
…onGH-109020)

(cherry picked from commit f0f96a9)

Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Sep 6, 2023
…onGH-109020)

(cherry picked from commit f0f96a9)

Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
vstinner pushed a commit that referenced this issue Sep 7, 2023
…109020) (#109031)

GH-108202: Document ``calendar``'s command-line interface (GH-109020)
(cherry picked from commit f0f96a9)

Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Yhg1s pushed a commit that referenced this issue Sep 8, 2023
…109020) (#109030)

GH-108202: Document ``calendar``'s command-line interface (GH-109020)
(cherry picked from commit f0f96a9)

Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
@hugovk hugovk added the easy label Aug 15, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jan 3, 2025
…ythonGH-127608)

Document the following TextCalendar methods:
- formatday()
- formatmonthname()
- formatweekday()
- formatweekheader()
(cherry picked from commit bb73426)

Co-authored-by: Stan Ulbrych <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jan 3, 2025
…ythonGH-127608)

Document the following TextCalendar methods:
- formatday()
- formatmonthname()
- formatweekday()
- formatweekheader()
(cherry picked from commit bb73426)

Co-authored-by: Stan Ulbrych <[email protected]>
erlend-aasland pushed a commit that referenced this issue Jan 3, 2025
…H-127608) (#128441)

Document the following TextCalendar methods:
- formatday()
- formatmonthname()
- formatweekday()
- formatweekheader()

(cherry picked from commit bb73426)

Co-authored-by: Stan Ulbrych <[email protected]>
erlend-aasland pushed a commit that referenced this issue Jan 3, 2025
…H-127608) (#128440)

Document the following TextCalendar methods:
- formatday()
- formatmonthname()
- formatweekday()
- formatweekheader()

(cherry picked from commit bb73426)

Co-authored-by: Stan Ulbrych <[email protected]>
WolframAlph pushed a commit to WolframAlph/cpython that referenced this issue Jan 4, 2025
…ython#127608)

Document the following TextCalendar methods:
- formatday()
- formatmonthname()
- formatweekday()
- formatweekheader()
@erlend-aasland
Copy link
Contributor Author

I removed the easy label. Adding docs for the calendar module is controversial. Please read the OP and #108202 (comment).

erlend-aasland pushed a commit that referenced this issue Jan 6, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jan 6, 2025
…y` and `setfirstweekday` (pythonGH-127579)

(cherry picked from commit 953b49e)

Co-authored-by: Stan Ulbrych <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jan 6, 2025
…y` and `setfirstweekday` (pythonGH-127579)

(cherry picked from commit 953b49e)

Co-authored-by: Stan Ulbrych <[email protected]>
erlend-aasland pushed a commit that referenced this issue Jan 6, 2025
…ay` and `setfirstweekday` (GH-127579) (#128564)

(cherry picked from commit 953b49e)

Co-authored-by: Stan Ulbrych <[email protected]>
erlend-aasland pushed a commit that referenced this issue Jan 6, 2025
…ay` and `setfirstweekday` (GH-127579) (#128565)

(cherry picked from commit 953b49e)

Co-authored-by: Stan Ulbrych <[email protected]>
erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue Jan 6, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jan 7, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jan 7, 2025
erlend-aasland added a commit that referenced this issue Jan 7, 2025
erlend-aasland added a commit that referenced this issue Jan 7, 2025
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this issue Jan 8, 2025
…ython#127608)

Document the following TextCalendar methods:
- formatday()
- formatmonthname()
- formatweekday()
- formatweekheader()
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this issue Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir
Projects
Status: Todo
Development

No branches or pull requests

3 participants