-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
doctest
GitHub Actions job exits with 2
failing all recent PRs
#101639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
doctest
GitHub Actions job exits with 2
marking checks of all recent PRsdoctest
GitHub Actions job exits with 2
failing all recent PRs
I think the fundamental problem here is that the doc build/test process uses the newly built Python and third-party dependencies from PyPI. I don't think it's bad to test that certain things work in the new Python, but expecting installable packages for the target Python is a bit problematic for two reasons: the Python we're building may be too new for the packages (as in this case), or the Python may be too old (for example when building docs for an older Python that the dependencies have already stopped supporting). |
One of the Sphinx extensions we're using just released (in 0.8.0) support for generating images via Matplotlib, which depends on NumPy: sphinx-doc/sphinxext-opengraph#88 Even though we're not using the image generation there (yet, we may do later), it still attempts the install and import. The quick fix is to pin sphinxext-opengraph to 0.5.9. Alternatively, for the benefit of downstream redistributors, we did take care that if the extension isn't installed, it won't be used: Lines 27 to 33 in 7990324
For doctest, we could also make use of this and only install the key essentials for the test. |
Fixed by gh-101642. |
The
Docs / Doctest (pull_request)
check started to fail recently with the following job log:@colorfulappl found out that:
It looks like gh-101292 is the cause. We need to provide some sort of compatibility shim or a deprecation period until numpy introduces version-specific
#if
guards.The text was updated successfully, but these errors were encountered: