Fix the tests #76
Merged
Fix the tests #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
|
I already had CLA integration so I imagine that it just didn't yet know my new commit email. When trying to auth with GitHub I got an internal server error from CLA integration but it seems that the known emails for my GitHub account have still been updated by the CLA integration 🤔 Should I report this anywhere? |
|
The CLA bot fork is at https://github.com/ambv/cla-bot, issues can go to https://github.com/edgedb/cla-bot But the CLA bot is now happy (#76 (comment)):
|
Mariatta
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests introduced by #39 and #43 turned out to be faulty after combining them with the changes from #35.
Any chance for a hacktoberfest-accepted label btw? :)