Add support for Python 3.8 #675
Merged
+257
−182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the official recommendation of Python core devs. The code is taken from the current 3.7 branch.
It adds only one method for flow control. Copy it, as we've already copied the rest of the flow control implementation.
It's a better name for a function that writes bytes.
Codecov Report
@@ Coverage Diff @@
## master #675 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 28 30 +2
Lines 4382 4424 +42
Branches 407 408 +1
=====================================
+ Hits 4382 4424 +42
Continue to review full report at Codecov.
|
The bugs that were locking us on an old version are fixed.
* Don't pass the deprecated loop argument. * Ignore deprecation warnings for @asyncio.coroutine.
aaugustin
changed the title
aaugustin
force-pushed
the
replace-public-apis-dropped-silently-by-asyncio
branch
from
2e0a52b to
504c66c
Compare
Since version 7.0, when the server closes, it terminates connections with close code 1001 instead of canceling them.
WebSocketCommonProtocol.transport can be unset, but it cannot be None.
|
could we have a dev wheel on Pypi for Python-3.8rc1 ? |
Member
Author
|
Yeah, I should do that => #681 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #648.