Skip to content

Add httpx to install_requires #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2022

Conversation

xylar
Copy link
Contributor

@xylar xylar commented Jul 25, 2022

I believe this was missed in:
#28
and a test import without this package fails.

closes #32

I believe this was missed in:
python-pinot-dbapi#28
and a test import without this package fails.
@xiangfu0
Copy link
Contributor

lgtm,thx for fixing it!

@xiangfu0 xiangfu0 merged commit 0566ad9 into python-pinot-dbapi:master Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

httpx appears to be missing from requirements in setup.py
2 participants