Skip to content

httpx appears to be missing from requirements in setup.py #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xylar opened this issue Jul 24, 2022 · 2 comments · Fixed by #33
Closed

httpx appears to be missing from requirements in setup.py #32

xylar opened this issue Jul 24, 2022 · 2 comments · Fixed by #33

Comments

@xylar
Copy link
Contributor

xylar commented Jul 24, 2022

It appears that imports of the httpx package were added a few weeks ago but the corresponding package requirement is missing from:
https://github.com/python-pinot-dbapi/pinot-dbapi/blob/release-0.4.1/setup.py#L21-L24
@xiangfu0
Copy link
Contributor

Thanks for reporting! Do you want to submit a pR to fix it

@xylar
Copy link
Contributor Author

xylar commented Jul 24, 2022

Sure, no problem. I'll try to do that tomorrow.

@xylar xylar mentioned this issue Jul 25, 2022
Merged
@walterddr walterddr mentioned this issue Sep 27, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add httpx to install_requires xylar/pinot-dbapi
2 participants
@xiangfu0 @xylar