Skip to content

Conversation

@cosmix
Copy link
Contributor

@cosmix cosmix commented Feb 28, 2023

This PR fixes #595, by re-exporting parse().

parse() should be re-exported so that the user can just call pendulum.parse() as documented, given that the module is marked with py.typed.

No tests have been modified or added for this bugfix.

@cosmix
Copy link
Contributor Author

cosmix commented Mar 1, 2023

Note that the failing CI test has to do with the fact that the flake8 module that you're using seems to not like the import aliasing that needs to be used to fix the issue addressed by this PR and that exports the parse symbol in __init__.py.

For reference, I'm using the type checker rules listed on the pyright README here, but, to my understanding these are rules common to more type checkers for Python.

@Secrus
Copy link
Collaborator

Secrus commented Apr 23, 2025

Hi. Sorry for the delays, we are digging ourselves out of the pile of code debt. Could you please rebase your changes with the master branch so we can review and merge them?

@Secrus Secrus added this to the Pendulum 3.2 milestone Apr 23, 2025
@Secrus Secrus changed the title fixup: Fix #595 fix: pendulum.parse is not marked as exported Apr 23, 2025
@cosmix
Copy link
Contributor Author

cosmix commented Apr 23, 2025

@Secrus done.

@codspeed-hq
Copy link

codspeed-hq bot commented Apr 24, 2025

CodSpeed Performance Report

Merging #693 will not alter performance

Comparing cosmix:master (7ef1b0b) with master (91d0c1e)

Summary

✅ 1 untouched benchmarks

@Secrus Secrus merged commit 1034b18 into python-pendulum:master Apr 24, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pendulum.parse is not marked as exported (pyright type checker in VSCode)

3 participants