Skip to content

Issue #131 - Pin jsonschema to 3.2.0 #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
p1c2u merged 2 commits into from
Jan 13, 2022
Merged

Issue #131 - Pin jsonschema to 3.2.0 #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a827fb
Issue #131 - Pin jsonschema to 0.3.2
adammkelly Oct 1, 2021
ca4d68f
exclude future incompatible jsonschema versions
p1c2u Jan 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
jsonschema
jsonschema==3.2.0
Copy link

@sthagen sthagen Dec 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe remove that dependency completely as is being required already by the openapi-schema-validator dependency (and also remove from setup.cfg)?

Copy link
Collaborator

@p1c2u p1c2u Jan 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's true but we use jsonschema directly also and version requirements for these two libraries can be different.

Copy link

@sthagen sthagen Jan 11, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But pinning (==) on one side of two never solves such a different needs problem with pip - there must be intervals of versions so that pip can find a non-empty intersection with versions to choose from (as only a single version can be installed inside an environment.

Copy link
Collaborator

@p1c2u p1c2u Jan 11, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, this should be caret requirement ^3.2.0 before we move to 4.x

Copy link

@sthagen sthagen Jan 11, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@p1c2u caret reads a bit npmish to me, wouldn't that be jsonschema~=3.2.0 for requirements.txt if we are afraid of upstream future versions 3.3 and larger? Update: Ah, poetry accepts that ("^3.2.0") also in pyproject.toml.

Copy link
Collaborator

@p1c2u p1c2u Jan 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I plan to move the library to poetry, that's why

Copy link
Collaborator

@p1c2u p1c2u Jan 13, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sthagen this is just for requirements.txt which is used for testing environment. For setup.cfg I would set jsonschema<5.0.0to exclude future version with incompatible iter_errors.

openapi-schema-validator
PyYAML==5.3.1
six==1.12.0
Expand Down
2 changes: 1 addition & 1 deletion setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ python_requires = >= 2.7, != 3.0.*, != 3.1.*, != 3.2.*, != 3.3.*, != 3.4.*
setup_requires =
setuptools
install_requires =
jsonschema
jsonschema<5.0.0
openapi-schema-validator
PyYAML>=5.1
six
Expand Down