Skip to content

Conversation

@adammkelly
Copy link

No description provided.

@p1c2u
Copy link
Collaborator

p1c2u commented Dec 23, 2021

why it needs to be locked to version 3.2?

@@ -1,4 +1,4 @@
isodate
jsonschema
jsonschema==3.2.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would maybe >=3.2.0 be an option or is development so fast that users do not need wait long until a dependency is bumped? … and maybe sync the build data files also? I noticed that setup.cfg still has jsonschema>=3.0.0

@adammkelly
Copy link
Author

We got around this by adding jsonschema==3.2.0 in our requirements. What we were seeing at the time was this package tried to install jsonschema 4.0.0 which got openapi-schema-validator into a recursive loop which lasted longer than our worker timeout of 60 seconds. It never got past the schema validation.

Similar problem here: python-openapi/openapi-spec-validator#132

@sthagen
Copy link

sthagen commented Dec 23, 2021

Well, the spec validator requires the schema validator (this repo/package) - why specific the jsonschema explicitly downstream (in the spec validator requirements), when it is delivered upstream already? ... pinning to me is always a future problem (synchronized re-pinning or unpinning).
As both repos are under the same roof, why not coordinate by removing jsonschema dep form the spec-validator and add in here schema-validator a greater or equal pinning of the jsonschema depending on the required capabilities? ... JSON Schema 2020-12 draft comes to my mind ...

@p1c2u
Copy link
Collaborator

p1c2u commented Dec 29, 2021

jsonschema requirement will be update to fix deprecation warning hence closing this one.

@p1c2u p1c2u closed this Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants