Handle missing MIME type in MediaTypeFinder #371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jparise
changed the title
Codecov Report
@@ Coverage Diff @@
## master #371 +/- ##
==========================================
+ Coverage 73.23% 73.24% +0.01%
==========================================
Files 80 80
Lines 2391 2392 +1
==========================================
+ Hits 1751 1752 +1
Misses 640 640
Continue to review full report at Codecov.
|
It's possible for a response not to have a MIME type (mimetype=None). Previously, this would result in an exception from within fnmatch(): TypeError: expected str, bytes or os.PathLike object, not NoneType This change guards against that condition and raises MediaTypeNotFound instead. Tests have also been added for this module.
jparise
force-pushed
the
media_type_finder
branch
from
7703591 to
d064386
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible for a response not to have a MIME type (
mimetype=None).Previously, this would result in an exception from within
fnmatch():This change guards against that condition and raises
MediaTypeNotFoundinstead. Tests have also been added for this module.