Skip to content

Falcon2 support drop #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2021
Merged

Falcon2 support drop #353

merged 1 commit into from
Jun 8, 2021

Conversation

p1c2u
Copy link
Collaborator

@p1c2u p1c2u commented Jun 6, 2021

FalconOpenAPIRequestFactory accepts default_when_empty keyword argument.

Backward compatibilities:

  • FalconOpenAPIRequestFactory requires to be instantiated

@codecov
Copy link

codecov bot commented Jun 6, 2021

Codecov Report

Merging #353 (1c87469) into master (82738c3) will increase coverage by 0.33%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #353      +/-   ##
==========================================
+ Coverage   95.71%   96.05%   +0.33%     
==========================================
  Files          81       80       -1     
  Lines        1705     1697       -8     
==========================================
- Hits         1632     1630       -2     
+ Misses         73       67       -6     
Impacted Files Coverage Δ
openapi_core/contrib/falcon/handlers.py 100.00% <100.00%> (ø)
openapi_core/contrib/falcon/middlewares.py 100.00% <100.00%> (ø)
openapi_core/contrib/falcon/requests.py 100.00% <100.00%> (ø)
openapi_core/contrib/falcon/responses.py 92.30% <100.00%> (-0.55%) ⬇️
openapi_core/exceptions.py 90.74% <0.00%> (+1.85%) ⬆️
openapi_core/unmarshalling/schemas/exceptions.py 96.42% <0.00%> (+3.57%) ⬆️
openapi_core/templating/responses/exceptions.py 100.00% <0.00%> (+10.00%) ⬆️
openapi_core/validation/exceptions.py 100.00% <0.00%> (+12.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82738c3...1c87469. Read the comment docs.

@p1c2u p1c2u force-pushed the refactor/falcon2-support-drop branch 3 times, most recently from 6c3535c to 3c7822a Compare June 7, 2021 21:53
@p1c2u p1c2u force-pushed the refactor/falcon2-support-drop branch from 3c7822a to 1c87469 Compare June 8, 2021 07:08
@p1c2u p1c2u merged commit 246f52a into master Jun 8, 2021
@p1c2u p1c2u deleted the refactor/falcon2-support-drop branch June 8, 2021 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant