Skip to content

Conversation

@chreke
Copy link
Contributor

@chreke chreke commented Mar 26, 2020

Great work on this library, it's really cool!

I was looking for a way to add custom formatters and found the custom_formatters argument. I found it very useful, so I thought I'd add it to the documentation.

I'm not sure if the usage example I gave is the best (are you supposed to provide both validate and unmarshal in this case?) so I'd be happy to get suggestions on how to improve it.

I didn't find any contribution guidelines so I hope I'm doing this right!

Best regards,
@chreke

@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

Merging #228 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #228   +/-   ##
=======================================
  Coverage   96.79%   96.79%           
=======================================
  Files         123      123           
  Lines        2403     2403           
=======================================
  Hits         2326     2326           
  Misses         77       77           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89ec335...99371d7. Read the comment docs.

@p1c2u
Copy link
Collaborator

p1c2u commented Mar 26, 2020

Hi @chreke

thank you for the contribution. LGTM 👍

@p1c2u p1c2u merged commit dbd5036 into python-openapi:master Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants