Skip to content

Requests integration #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2020
Merged

Requests integration #209

merged 1 commit into from
Mar 3, 2020

Conversation

p1c2u
Copy link
Collaborator

@p1c2u p1c2u commented Mar 3, 2020

After finder introduction with path with variables resolving it's finally possible to implement requests integration.

  1. The request validator checks for a path variables in the request object.
  2. If empty gets it from the finder's path result.

Part of ##32

@p1c2u p1c2u force-pushed the feature/requests-integration branch 2 times, most recently from aaba8e8 to c06c2bb Compare March 3, 2020 09:54
@codecov
Copy link

codecov bot commented Mar 3, 2020

Codecov Report

Merging #209 into master will increase coverage by 0.04%.
The diff coverage is 97.67%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #209      +/-   ##
==========================================
+ Coverage   96.34%   96.38%   +0.04%     
==========================================
  Files         119      122       +3     
  Lines        2351     2378      +27     
==========================================
+ Hits         2265     2292      +27     
  Misses         86       86
Impacted Files Coverage Δ
openapi_core/validation/request/datatypes.py 100% <100%> (ø) ⬆️
openapi_core/contrib/requests/__init__.py 100% <100%> (ø)
openapi_core/contrib/requests/requests.py 100% <100%> (ø)
openapi_core/validation/request/validators.py 95.07% <100%> (+0.07%) ⬆️
openapi_core/contrib/requests/responses.py 100% <100%> (ø)
openapi_core/validation/response/validators.py 94.28% <83.33%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02d20e5...7e920f8. Read the comment docs.

This was referenced Mar 3, 2020
@p1c2u p1c2u force-pushed the feature/requests-integration branch 2 times, most recently from ccfbd84 to c48b731 Compare March 3, 2020 11:06
@p1c2u p1c2u force-pushed the feature/requests-integration branch from c48b731 to 7e920f8 Compare March 3, 2020 11:09
@p1c2u p1c2u merged commit c27cd89 into master Mar 3, 2020
@p1c2u p1c2u deleted the feature/requests-integration branch March 3, 2020 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants