Read cell comments in .xlsx files #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Works for the single file I've tried it on, for what that's worth. Could
do with a bit more testing.
Fixes python-excel/xlrd#37
…o feature-cell-comments-in-xlsx
This has test cases for .xlsx files generated by both Excel 2007 and Google Docs, and works for 't' elements nested directly under 'text' or with an intervening 'r' element. It also copes with the (common) Excel case where there are multiple 't' elements: this occurs when a comment has an emboldened author name
|
Your diagnosis of the 2.6 problem appears to be correct. One thing to fix: With the Excel UI it is quite possible to create a comment which contains no text. This is pointless but still valid. Please drop the warning, and create a Note object with text = a zero-length string i.e. not None. |
|
Good catch - thanks. I don't have access to a copy of Excel at present, but I'll add another test with code to deal with that case tomorrow. |
|
I've tested this patch with price files from Bitrix CMS and it seems OK for me. My environment is Mac OS X, Python 3.3.3 |
|
@stephenlewis - still waiting for you test to deal with the case @sjmachin raises... |
cjw296
added a commit
that referenced
this pull request
Jan 25, 2014
Read cell comments in .xlsx files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on the work done in #38.
It adds tests for parsing comments out of .xlsx files generated by Excel 2007 and Google Docs, and copes correctly with the two different comment structures identified in the previous pull request.