Skip to content

Conversation

@kmvanbrunt
Copy link
Member

Added a way to pause storing output in StdSim.

@codecov
Copy link

codecov bot commented Mar 10, 2019

Codecov Report

Merging #642 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #642      +/-   ##
==========================================
- Coverage   94.23%   94.23%   -0.01%     
==========================================
  Files          11       11              
  Lines        3020     3017       -3     
==========================================
- Hits         2846     2843       -3     
  Misses        174      174
Impacted Files Coverage Δ
cmd2/pyscript_bridge.py 100% <100%> (ø) ⬆️
cmd2/utils.py 98.63% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c7361d...16a337d. Read the comment docs.

@tleonhardt tleonhardt modified the milestones: 0.9.4, 0.9.11 Mar 10, 2019
Copy link
Member

@tleonhardt tleonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend the following:

  1. Update Changelog
  2. Add or update an example to show usage of this feature and/or update he Sphinx docs

manually you'll need to remove ``locals_in_py`` from the ``settable`` dictionary.

The ``app`` object (or your custom name) provides access to application commands
through either raw commands or through a python API wrapper. For example, any
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up this outdated documentation

@kmvanbrunt kmvanbrunt merged commit d9cd632 into master Mar 10, 2019
@kmvanbrunt kmvanbrunt deleted the store_output branch March 10, 2019 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants