-
Notifications
You must be signed in to change notification settings - Fork 124
Improvements to history command #635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
history -v with a string or regex search now searches both the entered command as well as the expanded command
Codecov Report
@@ Coverage Diff @@
## master #635 +/- ##
==========================================
+ Coverage 94.07% 94.21% +0.14%
==========================================
Files 10 11 +1
Lines 2954 3010 +56
==========================================
+ Hits 2779 2836 +57
+ Misses 175 174 -1
Continue to review full report at Codecov.
|
|
@kotfu @kmvanbrunt I hope you don't mind, but I took the liberty of putting this branch we have all contributed to (you two more than me) up for PR. It felt like it was time for the three of us to review the work everyone has done and hash out any remaining changes. |
kmvanbrunt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks goods. Good team effort on this change.
|
@kotfu I'm going to merge this PR so I can do a bunch of regression testing of the new features together. Feel free to still suggest changes. |
Summary
This PR contains numerous changes to the history command made by a mix of @kmvanbrunt, @kotfu, and @tleonhardt over the last few months. It feels like these changes are either done or almost done and it was high time to create a PR and hash out any last remaining details.
Details
Presentation format
The presentation format has been improved and simplified.
Current:
Before:
New flags
Refactoring
HistoryItemandHistoryclasses were moved from cmd2.py to a new history.pyHIstoryItemnow retains the fullStatementinstanceexpanded_command_lineproperty toHistoryItemImprovements
TODO
This closes #545