Fixed case where extra slash was printing when tab completing users on Windows #493
Conversation
Codecov Report
@@ Coverage Diff @@
## python2 #493 +/- ##
===========================================
- Coverage 89.81% 89.68% -0.13%
===========================================
Files 1 1
Lines 2091 2094 +3
===========================================
Hits 1878 1878
- Misses 213 216 +3
Continue to review full report at Codecov.
|
tleonhardt
left a comment
tleonhardt
left a comment
There was a problem hiding this comment.
Bump version to 0.8.9 in this PR
CHANGELOG.md
Outdated
| @@ -1,4 +1,8 @@ | |||
| ## 0.8.8 (TBD, 2018) | |||
| ## 0.8.9 (TBD 2018) | |||
There was a problem hiding this comment.
Recommend putting this as (August TBD, 2018) since we officially abandon support for Python 2.7 on August 31, 2018.
Also, since this is prepping for the 0.8.9 release for Python 2.7, you should bump the version number to 0.8.9 in this PR in all 4 required places:
- setup.py
- cmd2.py
- docs/conf.py
- tests/test_cmd2.py
NOTE: On master now, we have completely changed the version scheme so there is no explicit version number anymore (it is based on the Git Tag).
| expanded_path = os.path.expanduser(text) | ||
| if os.path.isdir(expanded_path): | ||
| users.append(text + os.path.sep) | ||
| user = text |
|
Ignore the VSTS build for this PR - it isn't setup to install |
|
Consider if it would make sense to add a unit test for the new code |
|
|
||
|
|
||
| __version__ = '0.8.8' | ||
| __version__ = '0.8.9' |
I have fixed this same bug in the Python 3 version. That will be in a later pull request.