Raise a deprecation warning when evolve receives insta as a kw arg #1117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How bout we remove |
|
I think we should change the deprecation, actually. People still use it, because it works differently. I don't remember the use-case but there was one. :-/ |
ikonst
reviewed
Apr 3, 2023
hynek
force-pushed
the
deprecate-evolve-kw
branch
from
1e25f93 to
880644e
Compare
lol it was even you who found out: ericvsmith/dataclasses#42 (comment) |
ikonst
reviewed
Apr 4, 2023
ikonst
reviewed
Apr 4, 2023
|
Thanks for your help @ikonst – we've smuggled a small feature in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this looking ok @ikonst?
Fixes #1109