Relax solana version to be a range #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides the benefit of less dependency version clashes when users might have another dependency that has pinned its solana-* dependencies. Ran unit tests on 1.11 and 1.13
|
Can you confirm that 1.14 was not working? |
|
It was working on local tests, but looking at the GH workflow, I see that I didn't run bpf tests. Running those locally returns the below EDIT: never mind, I get the same error on 1.10, must be my local env |
ali-behjati
approved these changes
Oct 19, 2022
|
Thank you very much for your contribution. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides the benefit of less dependency version clashes when users might have another dependency that has pinned its solana-* dependencies.
Ran unit tests on 1.11 and 1.13.
Closes #79