-
Notifications
You must be signed in to change notification settings - Fork 60
An example contract for Solana #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One big thing I think we should definitely do is check the pyth account keys in the instruction. People are going to essentially copy-paste this code, so we should make sure that it's complete and secure.
Aside from that, I Ieft some minor comments around documentation etc.
Oh also you should install the pre-commit hooks here https://github.com/pyth-network/pyth-sdk-rs#pre-commit-hooks to fix this CI issue ^ |
Following Jayant's comments, I made the following changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome! I left a bunch of minor comments. I think you're getting pretty close though, so I suggest merging this PR and then addressing the comments in separate small PRs.
Hi Ali and Jayant, I resolved all your new comments. Specifically, I
I also followed Ali's suggestion and rebase my branch with the latest main. I guess two things worth another eye: |
I have been working with Ali on this example contract. Comments are welcome and I will address them before merge.