refactor observer #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cctdaniel
commented
May 6, 2024
Comment on lines
97
to
108
| # Handle potential None for min_publishers | ||
| if ( | ||
| price_account.min_publishers is None | ||
| or price_account.min_publishers >= 10 | ||
| ): | ||
| continue | ||
|
|
||
| # Ensure latest_block_slot is not None or provide a default value | ||
| latest_block_slot = ( | ||
| price_account.slot if price_account.slot is not None else -1 | ||
| ) | ||
|
|
There was a problem hiding this comment.
this is to fix pyright errors
ali-behjati
reviewed
May 6, 2024
| ) | ||
|
|
||
| # Cast the event to EventCreateRequest explicitly because pyright complains that the previous line returns UnparsedObject | Unknown | None | ||
| event = cast(EventCreateRequest, event) |
There was a problem hiding this comment.
So strange of pyright 🤔
ali-behjati
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
datetimelibrary as seen frompytzdocumentation itself: https://github.com/stub42/pytz/blob/master/src/README.rst#issues--limitationsrequirements.txtwhich is not needed since we are using poetrypythclient.calendaras the single source of truth instead of the calendar file in this repo which is not updated