Skip to content

Add small section on migrating from nose to pytest. #8048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2020
Merged

Add small section on migrating from nose to pytest. #8048

merged 1 commit into from
Nov 19, 2020

Conversation

@mickeypash
Copy link
Contributor

@mickeypash mickeypash commented Nov 18, 2020

This change was initiated after a discussion found here.

The section currently features the nose2pytest tool with plans to expand
on some of the common gotchas when performing such migrations.

Questions for reviewers:

  • Should I update the the CHANGELOG - I think it's not necessary.
  • Should I add myself to AUTHORS - the change seems pretty small so I'll leave it for now.

@nicoddemus
Copy link
Member

nicoddemus commented Nov 18, 2020

Should I update the the CHANGELOG - I think it's not necessary.

I don't think it is necessary; I believe only sweeping changes to the documentation are useful to be added to the CHANGELOG. 👍

Should I add myself to AUTHORS - the change seems pretty small so I'll leave it for now.

Yes by all means. 😁

nicoddemus
nicoddemus requested changes Nov 18, 2020
View reviewed changes
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor adjustments. 👍

Thanks!

@mickeypash
Copy link
Contributor Author

mickeypash commented Nov 18, 2020

I've included your suggestions and added my name to AUTHORS by force pushing to my patch-1 branch. The change hasn't been reflected here.

@nicoddemus
Copy link
Member

nicoddemus commented Nov 18, 2020

I've included your suggestions and added my name to AUTHORS by force pushing to my patch-1 branch. The change hasn't been reflected here.

Hmmm seems like your fork might have been out of date? The builds seem broken...

@nicoddemus
Copy link
Member

nicoddemus commented Nov 18, 2020

(Let me know if you want me to rebase/force-push for you)

@mickeypash
Copy link
Contributor Author

mickeypash commented Nov 18, 2020

Yes please

@mickeypash
Copy link
Contributor Author

mickeypash commented Nov 19, 2020

Is there a way I can re-trigger the failed steps?

@mickeypash @nicoddemus
Add small section on migrating from nose to pytest
ce825ed 
The section currently features the nose2pytest tool with plans to expand
on some of the common gotchas when performing such migrations.
@nicoddemus
Copy link
Member

nicoddemus commented Nov 19, 2020

Is there a way I can re-trigger the failed steps?

Unfortunately not, only maintainers can re-trigger (except for pushing a new commit of course).

@nicoddemus nicoddemus merged commit 42f9622 into pytest-dev:master Nov 19, 2020
@nicoddemus
Copy link
Member

nicoddemus commented Nov 19, 2020

Thanks @mickeypash!

The-Compiler added a commit to The-Compiler/pytest that referenced this pull request Nov 19, 2020
@The-Compiler
Fix nose documentation
c6ac618 
Follow-up to pytest-dev#8048 which seems to have been merged without the suggested changes.
@The-Compiler The-Compiler mentioned this pull request Nov 19, 2020
Merged
@mickeypash mickeypash deleted the patch-1 branch November 20, 2020 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicoddemus nicoddemus nicoddemus requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mickeypash @nicoddemus