Changing key "error" to "errors" to maintain plurality #6905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @barrezuetai, Sorry for the long response time on this, but in the end we took a different approach in #7364. 👍 Hope we see other contributions from you in the future! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request was created to try and fix issue #6505
"error" has been changed to "errors" without affecting the user-facing text.
When testing the changes, there was one module that wouldn't pass (testing/test_junitxml.py).
I've tried to look deeper into this and saw that when an xmlschema is created, there is an node created instead of . It looks like the "s" is being dropped from "errors" in the junit-10.xsd file which ends up in creating that node.
I'm not sure where to look further in order to fix the failed test cases. If you know which direction I should take in order to fix this I'd gladly move in that direction. @blueyed