Unifying black version in pre-commit config file

[marcelotrevisani]

Should the black version be the same as that is being in use by the black hook?

[marcelotrevisani]

pytest/.pre-commit-config.yaml

Line 3 in 26a2e1a

rev: 19.10b0

[nicoddemus]

Hi @marcelotrevisani!

Should the black version be the same as that is being in use by the black hook?

What do you mean by "the black version"? IFAIK the pre-commit file it is the only place where we define which version of black we use.

[marcelotrevisani]

Hi @marcelotrevisani!

Should the black version be the same as that is being in use by the black hook?

What do you mean by "the black version"? IFAIK the pre-commit file it is the only place where we define which version of black we use.

Sorry, I think I was not clear. The pre-commit hook to run black is using the version 19.10 and the blacken-docs is set to use black 19.3. Am I right?
Does it make sense to unify the black versions? I know that they are going to be different envs, I just thought that would be good to run black using the same version.
It's just a very small thing, but you can close it if you think that is unnecessary :)

[hugovk]

Yes, makes sense to use the same newer version as here:

https://github.com/marcelotrevisani/pytest/blob/8dbf6a4b2d89b8cbffe53ee39aa98c27fe4714d8/.pre-commit-config.yaml#L3

[nicoddemus]

@marcelotrevisani thanks for the clarification, that was probably an oversight and we should be using the same version. 😁

[RonnyPfannschmidt]

@asottile i wonder if pre-commit could be extended to substitute the rev of other envs inside of extra deps?

[asottile]

pre-commit currently has no substitution and I don't want to change that