Skip to content

codecov: use only linux/windows/osx flags #4799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 24, 2019
Merged

codecov: use only linux/windows/osx flags #4799

merged 1 commit into from
Feb 24, 2019

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Feb 14, 2019

Using many flags are a reason for timeouts on their backend, and we do
not really need those.

@blueyed
Copy link
Contributor Author

blueyed commented Feb 14, 2019

@nicoddemus
This appears to have helped with timeouts over at awesomeWM/awesome#2648.

nicoddemus
nicoddemus approved these changes Feb 14, 2019
View reviewed changes
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @blueyed!

Out of curiosity, what's the difference between flags and env?

@codecov
Copy link

codecov bot commented Feb 14, 2019

Codecov Report

Merging #4799 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4799      +/-   ##
==========================================
+ Coverage   95.64%   95.66%   +0.01%     
==========================================
  Files         113      113              
  Lines       25054    25054              
  Branches     2488     2488              
==========================================
+ Hits        23963    23968       +5     
+ Misses        769      767       -2     
+ Partials      322      319       -3
Flag Coverage Δ
#docs ?
#doctesting ?
#linting ?
#linux 95.49% <ø> (+0.01%) ⬆️
#nobyte ?
#numpy ?
#pexpect ?
#pluggymaster ?
#py27 ?
#py34 ?
#py35 ?
#py36 ?
#py37 ?
#trial ?
#windows 93.7% <ø> (+0.61%) ⬆️
#xdist ?
Impacted Files Coverage Δ
src/_pytest/terminal.py 91.85% <0%> (+0.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b1f813...4da8e59. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 14, 2019 •
edited
Loading

Codecov Report

Merging #4799 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4799      +/-   ##
==========================================
- Coverage   95.74%   95.66%   -0.09%     
==========================================
  Files         113      113              
  Lines       25666    25163     -503     
  Branches     2505     2498       -7     
==========================================
- Hits        24575    24071     -504     
  Misses        772      772              
- Partials      319      320       +1
Flag Coverage Δ
#docs ?
#doctesting ?
#linting ?
#linux 95.48% <ø> (-0.11%) ⬇️
#nobyte ?
#numpy ?
#osx 93.3% <ø> (?)
#pexpect ?
#pluggymaster ?
#py27 ?
#py34 ?
#py35 ?
#py36 ?
#py37 ?
#py38 ?
#trial ?
#windows 93.68% <ø> (ø) ⬆️
#xdist ?
Impacted Files Coverage Δ
testing/test_modimport.py 81.81% <0%> (-1.52%) ⬇️
testing/code/test_source.py 95.53% <0%> (-1.07%) ⬇️
testing/test_argcomplete.py 68.11% <0%> (-0.9%) ⬇️
testing/test_compat.py 91.13% <0%> (-0.63%) ⬇️
testing/test_skipping.py 97.65% <0%> (-0.57%) ⬇️
src/_pytest/warnings.py 88.88% <0%> (-0.53%) ⬇️
src/_pytest/debugging.py 77.98% <0%> (-0.41%) ⬇️
src/_pytest/fixtures.py 97.91% <0%> (-0.31%) ⬇️
src/_pytest/logging.py 94.96% <0%> (-0.31%) ⬇️
testing/test_assertrewrite.py 83.55% <0%> (-0.3%) ⬇️
... and 73 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cf9c2e...1ec7f60. Read the comment docs.

@blueyed
Copy link
Contributor Author

blueyed commented Feb 14, 2019

@nicoddemus
Flags are being reported in the comment, and can be selected for coverage overlay in the file detail view.
Env vars appear to only show up with the build info.

@blueyed
Copy link
Contributor Author

blueyed commented Feb 14, 2019

Unfortunately https://codecov.io/gh/pytest-dev/pytest/pull/4799?src=pr&el=h1 still times out here.

@blueyed
Copy link
Contributor Author

blueyed commented Feb 14, 2019

Asked codecov support about this.
Let's hold this back for now.

@blueyed blueyed changed the title codecov: pass TOXENV, use only linux/windows flags [WIP] codecov: pass TOXENV, use only linux/windows flags Feb 14, 2019
blueyed
blueyed commented Feb 14, 2019
View reviewed changes
.travis.yml Outdated
@@ -105,7 +105,7 @@ after_success:
coverage combine
coverage xml --ignore-errors
coverage report -m --ignore-errors
bash <(curl -s https://codecov.io/bash) -Z -X gcov -X coveragepy -X search -X xcode -X gcovout -X fix -f coverage.xml -F "${TOXENV//-/,},linux"
bash <(curl -s https://codecov.io/bash) -Z -X gcov -X coveragepy -X search -X xcode -X gcovout -X fix -f coverage.xml -e TOXENV
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re flags: we have macos here also.

@blueyed
Copy link
Contributor Author

blueyed commented Feb 14, 2019

Support indicated that number of uploads is also relevant likely (of course), and we're doing quite a lot.
They asked about 10, but we're doing 20 (https://codecov.io/gh/pytest-dev/pytest/commit/2106515f6d5757f2717efcdb71d6e7a55620f34b/build).

@nicoddemus
What do you think about reducing number of uploads?
How many should we have, only around 10 maybe?

@nicoddemus
Copy link
Member

By "uploads" you mean builds that finish and upload coverage, correct?

@blueyed
Copy link
Contributor Author

blueyed commented Feb 14, 2019

Yes.

@blueyed
Copy link
Contributor Author

blueyed commented Feb 14, 2019

We might still upload more to Code Climate (#4800), but maybe also not running with coverage all the time would benefit performance (of course).

@blueyed
codecov: use only linux/windows flags
1ec7f60 
Using many flags are a reason for timeouts on Codecov's backend.
@blueyed blueyed changed the title [WIP] codecov: pass TOXENV, use only linux/windows flags [WIP] codecov: use only linux/windows/osx flags Feb 23, 2019
@blueyed blueyed changed the title [WIP] codecov: use only linux/windows/osx flags codecov: use only linux/windows/osx flags Feb 23, 2019
@nicoddemus nicoddemus merged commit a0f5c4c into pytest-dev:master Feb 24, 2019
This was referenced Feb 26, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blueyed @nicoddemus