Skip to content

Conversation

The-Compiler
Copy link
Member

This got added in 38fb6aa, where the "The return value ... changed" made a lot of sense. However, 9c5da9c removed the "versionadded" without adjusting the wording.

Also see 3a4435f.

This got added in 38fb6aa, where the "The
return value ... changed" made a lot of sense. However,
9c5da9c removed the "versionadded" without
adjusting the wording.

Also see 3a4435f.
Several improvements.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another leftover I noticed when reviewing the original commit. I think it got hidden as a comment because it's intended under the .. regendoc: wipe.

@The-Compiler The-Compiler added skip news used on prs to opt out of the changelog requirement backport 8.3.x labels Feb 13, 2025
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@The-Compiler The-Compiler merged commit 62aa427 into pytest-dev:main Feb 15, 2025
28 checks passed
Copy link

patchback bot commented Feb 15, 2025

Backport to 8.3.x: 💚 backport PR created

✅ Backport PR branch: patchback/backports/8.3.x/62aa4272229a4e604582db534796df1a729b4752/pr-13222

Backported as #13225

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Feb 15, 2025
This got added in 38fb6aa, where the "The
return value ... changed" made a lot of sense. However,
9c5da9c removed the "versionadded" without
adjusting the wording.

Also see 3a4435f.

(cherry picked from commit 62aa427)
The-Compiler added a commit that referenced this pull request Feb 15, 2025
This got added in 38fb6aa, where the "The
return value ... changed" made a lot of sense. However,
9c5da9c removed the "versionadded" without
adjusting the wording.

Also see 3a4435f.

(cherry picked from commit 62aa427)

Co-authored-by: Florian Bruhin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news used on prs to opt out of the changelog requirement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants