Run away from getfuncargvalue deprecation. #64
Conversation
|
I know... tests are failing but it's due to version conflicts which is out of scope of this PR. Should fix for it be included too or you prefer separate PR? |
|
Thanks @amateja for the PR. I'm not sure what pytest version is supposed to be supported by pytest-flask, but if it is >= 3.0 |
pytest_flask/pytest_compat.py
Outdated
| if hasattr(request, 'getfixturevalue'): | ||
| return request.getfixturevalue(value) | ||
|
|
||
| return request(value) |
There was a problem hiding this comment.
Shouldn't this be return request.getfuncargvalue(value)?
|
About if it is OK to fix the build on this PR or in another one, the maintainers must decide. 😁 |
|
I'm not sure if this is fixable easily. Some package in dependency chain requires pytest>=2.7.0 and we are testing against 2.6.x. We have two options - drop testing against 2.6.x (which is not an direct equivalent of dropping support) or track down that dependency and pin its version in tox deps matrix. |
|
Found it! It is because of recent changes in pytest-xdist. Will try to propose a workaround. |
|
IMHO dropping support for pytest < 2.7.0 is reasonable, 2.6.4 was released in Oct 24, 2014. |
|
Actually dropping support for pytest 2.6.x might be reasonable. According to pytest changelog python 3.5+ is supported only by pytest 2.7.3+. Keeping in mind that python 2.6 is deprecated and 3.3 is going to be deprecated this year dependency matrix is going to be not that beautiful. Moreover pytest 3.1 was released couple days ago so we might add it to test suite. |
|
Hi, @amateja! Thank you so much for your contribution! |
|
@nicoddemus Could you release this on pypi? |
|
@remcohaszing I publish a new release on this weekend. Thank you for patience. |
|
@vitalk could you also add me as maintainer in PyPI? Thanks! |
Howdy!
Here you have a patch for deprecated getfuncargvalue method. This PR is based on pytest-dev/pytest-django#393.
Cheers!