Fix "db access not allowed" with both transactional_db and db fixtures #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new helper method (`_django_db_fixture_helper`), which is being called from `db` and `transaction_db`. The intermediate helper function (in contrast to using an internal fixture) is necessary for setting up the `django_db` mark. Fixes pytest-dev#126
|
@pelme |
|
Looks good to me! Feel free to add a note to the changelog too. I have been lagging a bit with the changelog for other commits and will go through them all before the next release, but starting now is better than later. :-) |
|
Merged (squashed) in c552fed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #126