Skip to content

Conversation

joroy
Copy link

@joroy joroy commented Jul 27, 2016

Add support for Qt Test
Add plugin tests (manual)

Travis integration cannot be implemented because QT lack support for unattended install.
To manually test the plugin, install QT somewhere and update the QT5DIR variable in tests/SConstruct file. Build of the QT5 tests file is possible because the SCons qt5 tool as been installed in the tests directory.

To build and run the tests:

  • scons -C tests
  • tox

@nicoddemus
Copy link
Member

Hey @joroy, many thanks for the PR!

I have a couple of questions/issues:

  1. I don't know QTest (and I'm short on time to research myself right now, sorry), but does it come bundled with Qt or is a separate tool?
  2. In pytest-qt's travis file I use a small script to install PyQt5 on Travis. Can't we use a similar approach to install Qt5/QTest on Travis?
  3. I really don't like bundling the scons qt tool with the project. I see two other options:
    1. if we manage to install QTest on Travis, do something similar to install the scons qt tool.
    2. If the above turns out to be impossible, we could ask users to install the scons qt tool manually in the same manner they already would have to do with QTest.

It is really important to me, as a maintainer, to have a reliable CI tool so I can merge contributions from others without having to resort to manually test things, that's why I must insist we find some solution for the test suite to run completely on Travis.

As for the rest of the code I don't have time right now to review it, but I would rather we figure the answer to the questions above first. 😁

Thanks again!

@joroy joroy closed this Jul 27, 2016
@joroy joroy deleted the qtestlib branch July 27, 2016 15:44
@nicoddemus nicoddemus mentioned this pull request Jul 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants