-
Notifications
You must be signed in to change notification settings - Fork 165
Address invisible hidden files in artifact upload action #941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
If we simply emit a warning (the default), the pipeline will fail during the check step when trying to combine the coverage data. By changing this from warning to error, we fail the pipeline earlier and save time debugging issues.
1fa7409
to
fd32446
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #941 +/- ##
==========================================
- Coverage 91.30% 91.10% -0.20%
==========================================
Files 2 2
Lines 506 506
Branches 98 98
==========================================
- Hits 462 461 -1
- Misses 26 27 +1
Partials 18 18 ☔ View full report in Codecov by Sentry. |
Coverage writes coverage reports to ".coverage" by default. The GitHub action "upload-artifact" no longer includes hidden files by default. This patch changes the coverage file name to a non-hidden file path.
fd32446
to
cd06de6
Compare
Nb: you could have also reenabled hidden file upload in the action with a flag |
@Tinche Thanks for the review! Before this PR, each tox environment created its own coverage file in the project root directory. They don't get overwritten either, so the developer has to clean up the files manually every now and then. I found this a bit annoying. I considered the |
Coverage writes reports to ".coverage" by default. The GitHub action "upload-artifact" no longer includes hidden files by default. This patch changes the coverage file name to a non-hidden file path.
This fixes the failing CI pipeline for pull requests.