Use colorama to get console width on Win32 #198
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failed build worked on my fork: https://github.com/stephenrauch/py/branches |
|
flaky test, a rerun worked 👍 please rebase |
RonnyPfannschmidt
requested changes
Aug 28, 2018
| import termios,fcntl,struct | ||
| call = fcntl.ioctl(1,termios.TIOCGWINSZ,"\000"*8) | ||
| height,width = struct.unpack( "hhhh", call ) [:2] | ||
| if colorama is None: |
There was a problem hiding this comment.
this platform check is incorrect, as colorama might be installed on non-windows environments
There was a problem hiding this comment.
i just noted that the same code is down below
so this is basically bad code duplication (see the win32 object handling)
There was a problem hiding this comment.
Up near the top of the file is:
colorama = None
if sys.platform == "win32":
try:
import colorama
colorama will be None in non-windows environments since the import will not be attempted.
stephenrauch
force-pushed
the
win32-width-from-colorama
branch
from
67a47fa to
bc63caf
Compare
|
I think we can close this in favor of #201. |
|
@nicoddemus |
|
@blueyed also added you as collaborator here. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.