Skip to content

Conversation

erooke
Copy link
Contributor

@erooke erooke commented Jun 20, 2024

test_reduce_node_name assumes the root directory of the source code is called pytask. This may not be true for a variety of reasons.

Changes

Replaces the string pytask with __ROOT.name in the expected output for test_reduce_node_name.

Todo

  • Reference issues which can be closed due to this PR with "Closes #x".
  • Review whether the documentation needs to be updated.
  • Document PR in docs/changes.rst.

I could not find the file docs/changes.rst

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.50%. Comparing base (ad3680e) to head (76eac35).
Report is 71 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #620      +/-   ##
==========================================
- Coverage   97.80%   97.50%   -0.31%     
==========================================
  Files         106      111       +5     
  Lines        8710     9257     +547     
==========================================
+ Hits         8519     9026     +507     
- Misses        191      231      +40     
Flag Coverage Δ
end_to_end 84.61% <ø> (+2.34%) ⬆️
integration 40.75% <ø> (+0.26%) ⬆️
unit 65.65% <ø> (-4.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tobiasraabe tobiasraabe merged commit daafee5 into pytask-dev:main Jun 24, 2024
@tobiasraabe
Copy link
Member

@erooke, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants