Skip to content

Invalidate cache to check whether remote files exist. #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Invalidate cache to check whether remote files exist. #591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/source/changes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ releases are available on [PyPI](https://pypi.org/project/pytask) and
- {pull}`587` improves typing of `capture.py`.
- {pull}`588` resets class variables of `ExecutionReport` and `Traceback`.
- {pull}`590` fixes an error introduced in {pull}`588`.
- {pull}`591` invalidates the cache of fsspec when checking whether a remote file
exists. Otherwise, a remote file might be reported as missing although it was just
created. See https://github.com/fsspec/s3fs/issues/851 for more info.

## 0.4.6 - 2024-03-13

Expand Down
7 changes: 7 additions & 0 deletions src/_pytask/nodes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

from attrs import define
from attrs import field
from upath import UPath
from upath._stat import UPathStatResult

from _pytask._hashlib import hash_value
Expand Down Expand Up @@ -376,6 +377,12 @@ def _get_state(path: Path) -> str | None:
A simple function to handle local and remote files.

"""
# Invalidate the cache of the path if it is a UPath because it might have changed in
# a different process with pytask-parallel and the main process does not know about
# it and relies on the cache.
if isinstance(path, UPath):
path.fs.invalidate_cache()

try:
stat = path.stat()
except FileNotFoundError:
Expand Down