-
Notifications
You must be signed in to change notification settings - Fork 11
Enhance the tutorial on how to set up a project. #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@hmgaudecker, I mention only the old setup.py approach since I documenting setuptools-scm feels like taking a big detour. What do you think? Is it fine although it is then not fully alinged with the template? |
Codecov Report
@@ Coverage Diff @@
## main #217 +/- ##
=======================================
Coverage 93.97% 93.97%
=======================================
Files 75 75
Lines 6671 6671
=======================================
Hits 6269 6269
Misses 402 402
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
TBH, it sounds a bit like this will end up in documentation hell, leaving users confused. IIUC, the same should be possible replacing |
What you need to set up to achieve the same behavior is
Although, it makes the tutorial longer, at least it is consistent. |
What do you mean by "the same behavior"? Finding the stuff in |
With the same behavior I mean: finding stuff in src, adding metadata to the package, setting a version (dynamically via setuptools-scm or static via the This can be done all in setup.py. Simple but inconsistent. Or you need to do the four points from the post above. Consistent, but more documentation. pyproject toml is used by setuptools-scm to store information on how to build the package. |
Great, thanks! I still don't quite understand why all four steps are needed. A little research, maybe too shallow...
In case I am not mistaken, it would just be |
Exactly for the extra comfort :). Releasing a new version just becomes writing a new release on Github with a tag. This pip version is from last April. I guess I am fine with that. I dont know why someone runs on an older version. |
Yeah, that's why I would keep that in the templates, but I agree with you ^^^^^ that documenting it here would be a bit of a detour.
Cool. So While you are at it: I would change
to
Most people will not do that very often. |
Hi @hmgaudecker, it is done. If you'd like, you can have a final look and then we merge it. Thanks for the discussion! |
Great, thank you! |
Changes
Follow-up to pytask-dev/cookiecutter-pytask-project#8 (comment)
conda develop
.