-
Notifications
You must be signed in to change notification settings - Fork 0
Harmonize with new version of econ-project-templates. #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
{{cookiecutter.project_slug}}/src/{{cookiecutter.project_slug}}/config.py
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #8 +/- ##
===========================================
- Coverage 97.22% 80.89% -16.33%
===========================================
Files 2 4 +2
Lines 72 89 +17
===========================================
+ Hits 70 72 +2
- Misses 2 17 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@tobiasraabe -- related to pytask-dev/pytask#217, is it enough to just remove |
Yes, and require pip >= 21.1. |
…b.com/tobiasraabe/cookiecutter-pytask into harmonize-with-econ-project-templates
What about the last open point? I am not sure about having predefined docs, since it can be tedious to keep it up-to-date with sphinx. On the other hand, there are some things which are always handy and you might want to consider for econ-project-templates.
|
Just a very small stub? The readthedocs template not make too much sense otherwise? Will have to keep up with a little bit over on econ-project-templates anyhow...
The latter is included, the former we should include! |
Anyhow, I don't expect to finish this PR before OpenSourceEconomics/econ-project-templates#98 is basically done. Unless you prefer to merge and open a new one should we see stuff in the meantime. My goal is that econ-project-templates ends up as a superset of this one. |
…b.com/tobiasraabe/cookiecutter-pytask into harmonize-with-econ-project-templates
@hmgaudecker, I am fine with opening more PRs if changes are necessary. This one is already too big. If you dont have any objections, I will merge it. |
Sounds great -- you are the boss, anyhow! Looking at the docs, the only question is whether we can use the automated versioning machinery for the documentation of the template itself? That is, something like from importlib.metadata import version in Other than that, this looks great. The only reason I might feel like keeping this PR open is to increase the chances of making improvements here instead of implementing workarounds in the corresponding econ-project-templates PR. @timmens, please feel free to open another one as you see fit! (@tobiasraabe, do you mind adding Tim to this repo?) |
I implemented versioning with setuptools-scm for the cookiecutter itself. Nice catch! Apart from that, I am happy to accept more PRs and merge this one now. I'll also add @timmens to the repo. In the future, I would like people who are more loosely related than Tim to fork the repo. |
Closes #5.
Sync with OpenSourceEconomics/econ-project-templates#98
add setup.py ? Mentioned in best practices of pytask docs. In any case,harmonise. Only keep pyproject.toml and setup.cfg as explained in the tutorial.:target: https://pypi.org/project/pytask
correct? (Fixed)ISSUE_TEMPLATE
in capital letters andpull_request_template.md
not? Github requirement? I almost missed the latter... (use uppercase folders to store multiple templates)