Skip to content

Add rudimentary typing to pytask. #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 40 commits into from
Dec 13, 2021
Merged

Add rudimentary typing to pytask. #160

merged 40 commits into from
Dec 13, 2021

Conversation

tobiasraabe
Copy link
Member

@tobiasraabe tobiasraabe commented Dec 5, 2021

Changes

Provide a description and/or bullet points to describe the changes in this PR.

@tobiasraabe tobiasraabe added this to the v0.1.4 milestone Dec 5, 2021
@codecov
Copy link

codecov bot commented Dec 5, 2021

Codecov Report

Merging #160 (730acde) into main (66e9483) will decrease coverage by 0.49%.
The diff coverage is 89.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #160      +/-   ##
==========================================
- Coverage   93.33%   92.84%   -0.50%     
==========================================
  Files          69       69              
  Lines        6015     6272     +257     
==========================================
+ Hits         5614     5823     +209     
- Misses        401      449      +48     
Flag Coverage Δ
end_to_end 77.10% <88.10%> (+0.09%) ⬆️
integration 41.54% <81.08%> (+1.49%) ⬆️
unit 70.53% <86.96%> (+0.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/test_dag.py 96.62% <25.00%> (-1.08%) ⬇️
tests/test_nodes.py 92.12% <25.00%> (-1.37%) ⬇️
src/_pytask/logging.py 90.00% <65.21%> (-7.65%) ⬇️
src/_pytask/capture.py 85.81% <69.44%> (-0.78%) ⬇️
src/_pytask/persist.py 91.17% <70.00%> (-8.83%) ⬇️
src/_pytask/mark_utils.py 83.33% <77.77%> (-16.67%) ⬇️
src/_pytask/skipping.py 95.58% <78.57%> (-4.42%) ⬇️
src/_pytask/debugging.py 33.46% <80.00%> (+3.29%) ⬆️
src/_pytask/mark/expression.py 97.58% <80.00%> (-0.77%) ⬇️
src/_pytask/clean.py 90.97% <86.11%> (-1.22%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66e9483...730acde. Read the comment docs.

@tobiasraabe tobiasraabe changed the title Add typing to pytask. Add rudimentary typing to pytask. Dec 12, 2021
@tobiasraabe tobiasraabe merged commit 9bccf7d into main Dec 13, 2021
@tobiasraabe tobiasraabe deleted the typing branch December 13, 2021 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant